Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing for vrfd address-family export map #6276

Merged
merged 3 commits into from Oct 5, 2020
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Oct 3, 2020

Fixes #6235

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #6276 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6276      +/-   ##
============================================
- Coverage     72.92%   72.90%   -0.02%     
+ Complexity    35028    35018      -10     
============================================
  Files          2832     2832              
  Lines        142317   142323       +6     
  Branches      17090    17090              
============================================
- Hits         103782   103760      -22     
- Misses        30311    30331      +20     
- Partials       8224     8232       +8     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.87% <ø> (-0.14%) 492.00 <0.00> (-1.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.41% <100.00%> (+0.03%) 1205.00 <1.00> (+1.00)
...fish/representation/cisco/CiscoStructureUsage.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...c/main/java/org/batfish/dataplane/rib/RibTree.java 88.33% <0.00%> (-1.67%) 28.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.25% <0.00%> (-1.24%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.42% <0.00%> (-0.95%) 250.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.69% <0.00%> (-0.47%) 245.00% <0.00%> (-2.00%)
... and 3 more

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @ratulm)


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoParser.g4, line 1881 at r1 (raw file):

DEC?

what is this DEC? name it?

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit 072cf9b into master Oct 5, 2020
@dhalperi dhalperi deleted the parse-vrfd-af-export-map branch October 5, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco IOS VRF export maps not recognized
3 participants