New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing for vrfd address-family export map #6276
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6276 +/- ##
============================================
- Coverage 72.92% 72.90% -0.02%
+ Complexity 35028 35018 -10
============================================
Files 2832 2832
Lines 142317 142323 +6
Branches 17090 17090
============================================
- Hits 103782 103760 -22
- Misses 30311 30331 +20
- Partials 8224 8232 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @ratulm)
projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoParser.g4, line 1881 at r1 (raw file):
DEC?
what is this DEC
? name it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Fixes #6235