New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow interface names in more distribute-list places #6345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6345 +/- ##
=========================================
Coverage 72.97% 72.97%
- Complexity 35133 35153 +20
=========================================
Files 2829 2829
Lines 142698 142769 +71
Branches 17148 17160 +12
=========================================
+ Hits 104134 104189 +55
- Misses 30335 30346 +11
- Partials 8229 8234 +5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-reviewer:@dhalperi +reviewer:@arifogel
Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @arifogel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ratulm)
projects/batfish/src/test/resources/org/batfish/grammar/cisco/testconfigs/ios-eigrp-distribute-list-refs-and-warnings, line 31 at r1 (raw file):
distribute-list prefix PL_IN gateway PL_GW_IN in distribute-list prefix PL_IN in GigabitEthernet0/0 distribute-list gateway PL_GW_IN in
Test for gateway with interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
No description provided.