Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interface names in more distribute-list places #6345

Merged
merged 4 commits into from Oct 26, 2020
Merged

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Oct 21, 2020

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #6345 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6345   +/-   ##
=========================================
  Coverage     72.97%   72.97%           
- Complexity    35133    35153   +20     
=========================================
  Files          2829     2829           
  Lines        142698   142769   +71     
  Branches      17148    17160   +12     
=========================================
+ Hits         104134   104189   +55     
- Misses        30335    30346   +11     
- Partials       8229     8234    +5     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 85.88% <ø> (ø) 492.00 <0.00> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 65.57% <100.00%> (+0.11%) 1215.00 <0.00> (+6.00)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...rammar/palo_alto/PaloAltoConfigurationBuilder.java 87.48% <0.00%> (-0.95%) 463.00% <0.00%> (+11.00%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)
...h/representation/juniper/JuniperConfiguration.java 88.43% <0.00%> (+0.01%) 462.00% <0.00%> (+1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.91% <0.00%> (+0.03%) 246.00% <0.00%> (ø%)
...batfish/representation/palo_alto/SecurityRule.java 91.30% <0.00%> (+0.39%) 19.00% <0.00%> (+1.00%)
...atfish/datamodel/collections/InsertOrderedMap.java 91.46% <0.00%> (+1.21%) 37.00% <0.00%> (+1.00%)
... and 2 more

@ratulm ratulm requested a review from dhalperi October 21, 2020 06:35
@dhalperi dhalperi requested review from arifogel and removed request for dhalperi October 26, 2020 19:00
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-reviewer:@dhalperi +reviewer:@arifogel

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @arifogel)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ratulm)


projects/batfish/src/test/resources/org/batfish/grammar/cisco/testconfigs/ios-eigrp-distribute-list-refs-and-warnings, line 31 at r1 (raw file):

  distribute-list prefix PL_IN gateway PL_GW_IN in
  distribute-list prefix PL_IN in GigabitEthernet0/0
  distribute-list gateway PL_GW_IN in

Test for gateway with interface?

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ratulm ratulm merged commit ca23a8a into master Oct 26, 2020
@ratulm ratulm deleted the eigrp-dist-list branch October 26, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants