Batfish: unusableVlanShutdown should only count active interfaces #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an interface is shutdown, it will not keep a Vlan up. (The autostate flag is still supported below).
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #6368 +/- ##
============================================
- Coverage 72.98% 72.97% -0.02%
+ Complexity 35164 35155 -9
============================================
Files 2829 2829
Lines 142779 142779
Branches 17160 17160
============================================
- Hits 104212 104191 -21
- Misses 30336 30351 +15
- Partials 8231 8237 +6 |
progwriter
reviewed
Oct 28, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
dhalperi
commented
Oct 28, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)
a discussion (no related file):
test
dhalperi
commented
Oct 28, 2020
There was a problem hiding this comment.
Reviewable status: 1 of 4 files reviewed, all discussions resolved
a discussion (no related file):
Previously, dhalperi (Dan Halperin) wrote…
test
Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an interface is shutdown, it will not keep a Vlan up. (The autostate flag is
still supported below).