Juniper: fix handling of "all" interface in OSPF area config #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not correctly inherit from the routing instance's master interface. This inserts that interface into the inheritance tree. Note this does not attempt to fix inheritance for fields that should be inherited, but are not.
|
This change is |
dhalperi
reviewed
Oct 29, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #6372 +/- ##
============================================
- Coverage 72.98% 72.97% -0.01%
+ Complexity 35167 35165 -2
============================================
Files 2829 2829
Lines 142795 142797 +2
Branches 17160 17160
============================================
Hits 104212 104212
- Misses 30348 30350 +2
Partials 8235 8235
|
progwriter
pushed a commit
to progwriter/batfish
that referenced
this pull request
Oct 29, 2020
progwriter
added a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not correctly inherit from the routing instance's master interface.
This inserts that interface into the inheritance tree.
Note this does not attempt to fix inheritance for fields that should be
inherited, but are not.