Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOSXE: recognize vasi left/right as valid interface prefixes #6375

Merged
merged 1 commit into from Oct 30, 2020

Conversation

progwriter
Copy link
Contributor

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #6375 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6375      +/-   ##
============================================
- Coverage     73.04%   73.03%   -0.01%     
  Complexity    35167    35167              
============================================
  Files          2815     2815              
  Lines        142679   142698      +19     
  Branches      17158    17168      +10     
============================================
+ Hits         104216   104219       +3     
- Misses        30229    30231       +2     
- Partials       8234     8248      +14     
Impacted Files Coverage Δ Complexity Δ
...tfish/representation/cisco/CiscoConfiguration.java 86.03% <100.00%> (+0.01%) 493.00 <0.00> (ø)
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-4.77%) 13.00% <0.00%> (-2.00%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) 90.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.60% <0.00%> (-0.31%) 245.00% <0.00%> (-1.00%)
...n/java/org/batfish/datamodel/BgpAdvertisement.java 52.63% <0.00%> (+0.02%) 21.00% <0.00%> (+4.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 90.90% <0.00%> (+1.36%) 51.00% <0.00%> (+1.00%)

@progwriter progwriter merged commit 691b96e into batfish:master Oct 30, 2020
@progwriter progwriter deleted the vasi-iface branch October 30, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants