-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOS: Parsing for track ip command #6378
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6378 +/- ##
============================================
- Coverage 73.05% 73.03% -0.02%
+ Complexity 35180 35170 -10
============================================
Files 2815 2815
Lines 142704 142704
Branches 17171 17171
============================================
- Hits 104248 104225 -23
- Misses 30215 30230 +15
- Partials 8241 8249 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ratulm)
projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoParser.g4, line 4073 at r1 (raw file):
: ( DEFAULT
Test for this alternative please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Fixes #6347