Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS: Parsing for track ip command #6378

Merged
merged 3 commits into from
Nov 3, 2020
Merged

IOS: Parsing for track ip command #6378

merged 3 commits into from
Nov 3, 2020

Conversation

ratulm
Copy link
Member

@ratulm ratulm commented Nov 2, 2020

Fixes #6347

@ratulm ratulm requested a review from arifogel November 2, 2020 07:21
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #6378 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6378      +/-   ##
============================================
- Coverage     73.05%   73.03%   -0.02%     
+ Complexity    35180    35170      -10     
============================================
  Files          2815     2815              
  Lines        142704   142704              
  Branches      17171    17171              
============================================
- Hits         104248   104225      -23     
- Misses        30215    30230      +15     
- Partials       8241     8249       +8     
Impacted Files Coverage Δ Complexity Δ
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.55%) 249.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.60% <0.00%> (-0.47%) 245.00% <0.00%> (-2.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.54% <0.00%> (-0.34%) 208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ratulm)


projects/batfish/src/main/antlr4/org/batfish/grammar/cisco/CiscoParser.g4, line 4073 at r1 (raw file):

:
  (
    DEFAULT

Test for this alternative please.

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ratulm ratulm merged commit 9259b96 into master Nov 3, 2020
@ratulm ratulm deleted the ios-track-ip branch November 3, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS - track structure not recognized
3 participants