Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXOS: support route-map set weight #6386

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

progwriter
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #6386 into master will decrease coverage by 0.00%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master    #6386      +/-   ##
============================================
- Coverage     73.07%   73.06%   -0.01%     
- Complexity    35199    35200       +1     
============================================
  Files          2815     2816       +1     
  Lines        142700   142712      +12     
  Branches      17172    17172              
============================================
- Hits         104282   104278       -4     
- Misses        30171    30185      +14     
- Partials       8247     8249       +2     
Impacted Files Coverage Δ Complexity Δ
...resentation/cisco_nxos/CiscoNxosConfiguration.java 88.09% <50.00%> (-0.05%) 358.00 <0.00> (ø)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 76.50% <100.00%> (+0.01%) 1033.00 <1.00> (+1.00)
...tfish/representation/cisco_nxos/RouteMapEntry.java 100.00% <100.00%> (ø) 54.00 <2.00> (+2.00)
...h/representation/cisco_nxos/RouteMapSetWeight.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.44% <0.00%> (-0.47%) 246.00% <0.00%> (ø%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.54% <0.00%> (-0.34%) 208.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)
... and 3 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit 1aada82 into batfish:master Nov 4, 2020
@progwriter progwriter deleted the nxos-set-weight branch November 4, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants