Cisco IOS: improve ospf->bgp redistribution, support matching on route types #6392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e types This fixes 3 bugs: 1. A spurious warning since ctx.MATCH() is a list and always non-null 2. Adds support for matching specific route types in redistribute statement 3. Not specifying match types means redistibuting both OSPF and OSPF_IA, not just OSPF (intra-area)
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #6392 +/- ##
============================================
- Coverage 73.07% 73.07% -0.01%
- Complexity 35222 35226 +4
============================================
Files 2817 2817
Lines 142760 142780 +20
Branches 17177 17181 +4
============================================
+ Hits 104326 104339 +13
- Misses 30182 30187 +5
- Partials 8252 8254 +2
|
dhalperi
reviewed
Nov 5, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3 bugs:
ctx.MATCH()is a list and always non-nullI'm aware this is a subpar solution and we need to make VS datamodel for redistribution more NXOS-like, but wasn't going to overhaul a lot of the VS model to unblock this bug fix.