BgpPeerConfigurationQuestion: add description column

[dhalperi]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6403 (6449ec5) into master (089d8da) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6403      +/-   ##
============================================
- Coverage     73.09%   73.08%   -0.02%     
+ Complexity    35240    35229      -11     
============================================
  Files          2817     2817              
  Lines        142801   142800       -1     
  Branches      17181    17181              
============================================
- Hits         104383   104366      -17     
- Misses        30170    30180      +10     
- Partials       8248     8254       +6     

Impacted Files	Coverage Δ	Complexity Δ
.../datamodel/questions/BgpPeerPropertySpecifier.java	89.83% <100.00%> (+0.17%)	17.00 <0.00> (ø)
...on/bgpproperties/BgpPeerConfigurationAnswerer.java	71.42% <100.00%> (-0.62%)	18.00 <0.00> (-2.00)
...rg/batfish/identifiers/StorageBasedIdResolver.java	85.29% <0.00%> (-5.89%)	22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java	83.67% <0.00%> (-4.09%)	18.00% <0.00%> (-1.00%)
...rc/main/java/org/batfish/datamodel/flow/Trace.java	80.64% <0.00%> (-3.23%)	13.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	59.52% <0.00%> (-1.20%)	15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	90.54% <0.00%> (-0.34%)	208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java	82.18% <0.00%> (-0.32%)	70.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java	86.19% <0.00%> (-0.28%)	249.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.91% <0.00%> (-0.16%)	246.00% <0.00%> (-1.00%)
... and 1 more

[corinaminer]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi and @ratulm)

---

projects/question/src/test/java/org/batfish/question/bgpproperties/BUILD, line 1 at r1 (raw file):

load("@rules_java//java:defs.bzl", "java_library")

i don't understand what change made this build file necessary now if it wasn't before

[corinaminer]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dhalperi and @ratulm)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/questions/BgpPeerPropertySpecifier.java, line 134 at r1 (raw file):

          .put(
              DESCRIPTION,
              new PropertyDescriptor<>(BgpPeerConfig::getDescription, Schema.STRING, "Description"))

could make the description of this property something like "Configured peer description", otherwise people looking at docs might think it's something batfish will manufacture.

[dhalperi]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @corinaminer, @dhalperi, and @ratulm)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/questions/BgpPeerPropertySpecifier.java, line 134 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

could make the description of this property something like "Configured peer description", otherwise people looking at docs might think it's something batfish will manufacture.

Done.

[dhalperi]

---

projects/question/src/test/java/org/batfish/question/bgpproperties/BUILD, line 1 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

i don't understand what change made this build file necessary now if it wasn't before

I want to run the tests alone, not as part of a huge suite.

[dhalperi]

---

projects/question/src/test/java/org/batfish/question/bgpproperties/BUILD, line 1 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

I want to run the tests alone, not as part of a huge suite.

This just moves these tests from the "question_tests" bazel target to the "bgpproperties:tests" target

[dhalperi]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ratulm)