BGP redistribution: set MED to IGP metric

[progwriter]

In the fullness of time this would be probably be done by routing policy because vendors may have knobs to control this behavior, but for now this is a default that seems to apply to big vendors

[batfish-bot]

This change is 

[corinaminer]

Reviewed 2 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved

[progwriter]

Did not expect this much difference in behavior. Closing pending some closer validation

[progwriter]

A more detailed investigation reveals that the main RIB for the example network is not affected. the BGP ribs are already not-as-correct-as-we-like so the changes reflected in the DP ref test do not make the situation any worse.

[corinaminer]

Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @progwriter)

---

projects/batfish/src/test/java/org/batfish/grammar/cisco/CiscoGrammarTest.java, line 3985 at r2 (raw file):

    EigrpRoute noMatchEigrp = internalRb.setNetwork(noMatchRm).build();

    // TODO BGP metric should match original route's metric

can remove this todo 😍
looks like you already rooted it out in the nxos test.

[codecov]

Codecov Report

Merging #6425 (7606923) into master (ff66fba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6425   +/-   ##
=========================================
  Coverage     73.30%   73.30%           
+ Complexity    35476    35474    -2     
=========================================
  Files          2824     2824           
  Lines        143432   143433    +1     
  Branches      17325    17325           
=========================================
+ Hits         105148   105149    +1     
+ Misses        29955    29952    -3     
- Partials       8329     8332    +3     

Impacted Files	Coverage Δ	Complexity Δ
...batfish/dataplane/protocols/BgpProtocolHelper.java	94.02% <100.00%> (+0.04%)	46.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java	84.61% <0.00%> (-15.39%)	7.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java	83.67% <0.00%> (-4.09%)	18.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	90.54% <0.00%> (-0.34%)	208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java	82.18% <0.00%> (-0.32%)	70.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.96% <0.00%> (+0.15%)	247.00% <0.00%> (ø%)
...ain/java/org/batfish/storage/FileBasedStorage.java	86.46% <0.00%> (+0.27%)	249.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	60.71% <0.00%> (+1.19%)	16.00% <0.00%> (+1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java	91.17% <0.00%> (+5.88%)	22.00% <0.00%> (ø%)

[progwriter]

Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @corinaminer)

---

projects/batfish/src/test/java/org/batfish/grammar/cisco/CiscoGrammarTest.java, line 3985 at r2 (raw file):

Previously, corinaminer (Corina Miner) wrote…

can remove this todo 😍
looks like you already rooted it out in the nxos test.

to-done.

[progwriter]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved