Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRR: fix NPE in routemaps for non-bgp routes #6453

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

progwriter
Copy link
Contributor

This is unlikely to correctly capture FRR semantics until we overhaul routing policy, but at least will prevent crashes.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #6453 (286069f) into master (42af8f4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6453      +/-   ##
============================================
- Coverage     73.18%   73.17%   -0.01%     
+ Complexity    35395    35393       -2     
============================================
  Files          2820     2820              
  Lines        143228   143228              
  Branches      17291    17292       +1     
============================================
- Hits         104816   104808       -8     
- Misses        30117    30123       +6     
- Partials       8295     8297       +2     
Impacted Files Coverage Δ Complexity Δ
...datamodel/routing_policy/statement/Statements.java 80.48% <100.00%> (ø) 2.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 60.37% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)

@progwriter progwriter merged commit 381d6ef into batfish:master Nov 21, 2020
@progwriter progwriter deleted the frr-ospf branch November 21, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants