Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASA: extract snmp source-interface and trap servers #6456

Merged
merged 1 commit into from Nov 24, 2020

Conversation

dhalperi
Copy link
Member

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #6456 (3cca1ce) into master (46b6ff8) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #6456      +/-   ##
============================================
- Coverage     73.18%   73.17%   -0.02%     
+ Complexity    35400    35394       -6     
============================================
  Files          2820     2820              
  Lines        143247   143257      +10     
  Branches      17302    17305       +3     
============================================
- Hits         104838   104830       -8     
- Misses        30114    30126      +12     
- Partials       8295     8301       +6     
Impacted Files Coverage Δ Complexity Δ
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 66.21% <57.14%> (-0.05%) 1249.00 <2.00> (ø)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) 8.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.54% <0.00%> (-0.34%) 208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.91% <0.00%> (-0.16%) 246.00% <0.00%> (-1.00%)

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 1300a11 into batfish:master Nov 24, 2020
@dhalperi dhalperi deleted the asa-snmp branch November 24, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASA: SNMP_Trap_Servers not parsed
3 participants