Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arista: port NX-OS route-map logic #6465

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Arista: port NX-OS route-map logic #6465

merged 2 commits into from
Dec 2, 2020

Commits on Dec 2, 2020

  1. Arista: port NX-OS route-map logic 

    Prior to this PR, Arista modeled route-maps as nested structures, so that if
there were N terms, those terms would go into a recursive structure that was N
terms deep. For large N (hundreds+) this can cause recursion limits in Java,
e.g., in walking the route-map or in serializing it to disk.

Fix this by adopting (neearly verbatim) the logic from NX-OS.

Validated by existing unit tests + Batfish Enterprise compare view: routes are
the same before and after in many real networks.
    @dhalperi
    dhalperi committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5e123f0 View commit details
    Browse the repository at this point in the history

  2. unsickbay test

    @dhalperi
    dhalperi committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    eee8c83 View commit details
    Browse the repository at this point in the history