Arista: add set tag and a test of route-map with continue #6466
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @arifogel, @dhalperi, and @progwriter)
projects/batfish/src/test/java/org/batfish/grammar/arista/AristaGrammarTest.java, line 2420 at r1 (raw file):
30 match metric 3
how do I read this? nothing in the route map matches (or sets) the metric to 3
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @dhalperi)
projects/batfish/src/test/java/org/batfish/grammar/arista/AristaGrammarTest.java, line 2420 at r1 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
30 match metric 3how do I read this? nothing in the route map matches (or sets) the metric to 3
I think I got it, nvm
projects/batfish/src/test/resources/org/batfish/grammar/arista/testconfigs/arista_route_map_exhaustive, line 19 at r2 (raw file):
route-map RM deny 30 match ip address pl30 set metric 10
should this be set metric 30? otherwise asserts in the test are trivial. and I'm guessing you want to test set isn't executed on deny
There was a problem hiding this comment.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @arifogel and @progwriter)
projects/batfish/src/test/java/org/batfish/grammar/arista/AristaGrammarTest.java, line 2420 at r1 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
I think I got it, nvm
Removed, stale.
projects/batfish/src/test/resources/org/batfish/grammar/arista/testconfigs/arista_route_map_exhaustive, line 19 at r2 (raw file):
Previously, progwriter (Victor Heorhiadi) wrote…
should this be
set metric 30? otherwise asserts in the test are trivial. and I'm guessing you want to test set isn't executed on deny
Yes, thanks.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @arifogel)
Codecov Report
@@ Coverage Diff @@
## master #6466 +/- ##
============================================
+ Coverage 73.19% 73.28% +0.09%
- Complexity 35415 35449 +34
============================================
Files 2820 2821 +1
Lines 143312 143320 +8
Branches 17306 17306
============================================
+ Hits 104896 105031 +135
+ Misses 30101 29960 -141
- Partials 8315 8329 +14
|
No description provided.