Arista: fixup #6465 with support for naked continue #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
And add another missing test.
dhalperi
force-pushed
the
arista-naked-continue
branch
from
cbd7ca5
to
15ec2e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6469 +/- ##
============================================
- Coverage 73.29% 73.28% -0.01%
+ Complexity 35458 35455 -3
============================================
Files 2822 2822
Lines 143314 143324 +10
Branches 17299 17301 +2
============================================
- Hits 105036 105034 -2
- Misses 29957 29966 +9
- Partials 8321 8324 +3
|
progwriter
reviewed
Dec 2, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add another missing test.