Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute bgp advertisements sent to outside, add route-leak testrigs #650

Merged
merged 1 commit into from
Nov 8, 2017
Merged

compute bgp advertisements sent to outside, add route-leak testrigs #650

merged 1 commit into from
Nov 8, 2017

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Nov 8, 2017 •
edited by dhalperi

This change is Reviewable

@ratulm
Copy link
Member

ratulm commented Nov 8, 2017

:lgtm:

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@ratulm ratulm merged commit f66468b into master Nov 8, 2017
@ratulm ratulm deleted the ari-route-leak-testrig branch November 8, 2017 00:45
@haverma
Copy link

haverma commented Nov 19, 2017 •
edited

@arifogel as a part of the issue, I have to add test for this PR. But I cannot figure out what exactly I have to test for this PR by looking at the code. Any pointers will be helpful !

haverma added a commit that referenced this pull request Dec 4, 2017
@haverma
This fixes #650
99487c7
haverma added a commit that referenced this pull request Dec 7, 2017
@haverma
Testing computeBgpAdvertisementsSentToOutside (#694)
f4724a5 
 This fixes #650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratulm ratulm ratulm approved these changes

@dhalperi dhalperi Awaiting requested review from dhalperi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arifogel @ratulm @haverma