Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceroute between tunnels: use GRE ip protocol #6521

Merged
merged 2 commits into from Dec 22, 2020

Conversation

progwriter
Copy link
Contributor

The flow construction todo fell through the cracks. Not using GRE protocol means interface ACLs would prevent tunnel edges from coming up

The flow construction todo fell through the cracks. Not using GRE protocol means interface ACLs would prevent tunnel edges from coming up
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #6521 (72877e8) into master (24a8dad) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6521      +/-   ##
============================================
- Coverage     73.36%   73.34%   -0.03%     
+ Complexity    35605    35590      -15     
============================================
  Files          2830     2830              
  Lines        143737   143738       +1     
  Branches      17365    17365              
============================================
- Hits         105455   105425      -30     
- Misses        29937    29956      +19     
- Partials       8345     8357      +12     
Impacted Files Coverage Δ Complexity Δ
...java/org/batfish/common/topology/TopologyUtil.java 90.99% <100.00%> (+0.02%) 157.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) 8.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...l/src/main/java/org/batfish/datamodel/FibImpl.java 88.52% <0.00%> (-2.46%) 29.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 60.37% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.42% <0.00%> (-0.55%) 245.00% <0.00%> (-3.00%)
... and 3 more

@progwriter progwriter merged commit 5715e65 into batfish:master Dec 22, 2020
@progwriter progwriter deleted the tunnel-tr-use-gre branch December 22, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants