IOS: bgp route-maps that are undefined deny all

[dhalperi]

No description provided.

[batfish-bot]

This change is 

[dhalperi]

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @corinaminer, @dhalperi, @progwriter, and @sfraint)

a discussion (no related file):
Self-merge only, since it's going to affect downstream repos and I need to prep fixups.

---

---

networks/example/candidate/configs/as2core2.cfg, line 110 at r1 (raw file):

  neighbor as3 peer-group
  neighbor as3 route-map filter-bogons in

FYI. To not change the behavior in the example network, I created an unused peer-group and put the undefined reference there.

[corinaminer]

Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi, @progwriter, and @sfraint)

---

networks/example/candidate/configs/as2core2.cfg, line 110 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

  neighbor as3 peer-group
  neighbor as3 route-map filter-bogons in

FYI. To not change the behavior in the example network, I created an unused peer-group and put the undefined reference there.

to be clear -- you mean to preserve the routing behavior? i assume the undefined route-map still counts as an undefined reference, right?

---

projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java, line 393 at r1 (raw file):

    }
    if (outboundRouteMapName != null) {
      peerExportConjuncts.add(new CallExpr(routeMapOrRejectAll(outboundRouteMapName, c)));

fyi: Wondering if it'd be more efficient if we put the common export policy as the last thing in the peer export conjuncts. Route map seems more likely to exclude more routes faster.

[dhalperi]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @progwriter and @sfraint)

---

networks/example/candidate/configs/as2core2.cfg, line 110 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

to be clear -- you mean to preserve the routing behavior? i assume the undefined route-map still counts as an undefined reference, right?

Yes.

[dhalperi]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @progwriter and @sfraint)

[codecov]

Codecov Report

Merging #6523 (cc2c03f) into master (c171295) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master    #6523      +/-   ##
============================================
- Coverage     73.36%   73.35%   -0.02%     
+ Complexity    35602    35594       -8     
============================================
  Files          2830     2830              
  Lines        143741   143754      +13     
  Branches      17365    17366       +1     
============================================
- Hits         105453   105447       -6     
- Misses        29941    29952      +11     
- Partials       8347     8355       +8     

Impacted Files	Coverage Δ	Complexity Δ
...batfish/representation/cisco/CiscoConversions.java	88.25% <94.11%> (+0.06%)	179.00 <3.00> (+1.00)
.../datamodel/routing_policy/statement/Statement.java	72.72% <0.00%> (-9.10%)	6.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java	85.29% <0.00%> (-5.89%)	22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java	83.67% <0.00%> (-4.09%)	18.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java	65.78% <0.00%> (-2.64%)	15.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	89.54% <0.00%> (-1.37%)	50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java	59.52% <0.00%> (-1.20%)	15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	90.72% <0.00%> (-0.34%)	207.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.81% <0.00%> (-0.31%)	247.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java	86.19% <0.00%> (-0.28%)	249.00% <0.00%> (ø%)