Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade jackson for CVE-2020-25649 #6547

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Jan 6, 2021

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #6547 (7c27dc3) into master (e76b3f2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6547      +/-   ##
============================================
- Coverage     73.37%   73.35%   -0.02%     
+ Complexity    35641    35632       -9     
============================================
  Files          2831     2831              
  Lines        143901   143901              
  Branches      17392    17392              
============================================
- Hits         105581   105559      -22     
- Misses        29955    29971      +16     
- Partials       8365     8371       +6     
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.57% <0.00%> (-0.55%) 246.00% <0.00%> (-2.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.90% <0.00%> (-0.34%) 208.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)
...tfish/representation/cisco/CiscoConfiguration.java 86.24% <0.00%> (-0.14%) 500.00% <0.00%> (-1.00%)

Copy link
Member

@sfraint sfraint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel, @corinaminer, and @progwriter)

@dhalperi dhalperi merged commit dfd8e96 into batfish:master Jan 6, 2021
@dhalperi dhalperi deleted the jackson-up branch January 6, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants