IOS VRF leaking: keep track of route targets

[progwriter]

Show data indicates that route target communities persist on the route after leaking

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6571 (669d86f) into master (f31dab4) will decrease coverage by 0.00%.
The diff coverage is 87.87%.

@@             Coverage Diff              @@
##             master    #6571      +/-   ##
============================================
- Coverage     73.39%   73.38%   -0.01%     
- Complexity    35719    35738      +19     
============================================
  Files          2837     2837              
  Lines        144177   144295     +118     
  Branches      17431    17460      +29     
============================================
+ Hits         105819   105898      +79     
- Misses        29972    29991      +19     
- Partials       8386     8406      +20     

Impacted Files	Coverage Δ	Complexity Δ
...h/representation/juniper/JuniperConfiguration.java	88.45% <ø> (-0.01%)	464.00 <0.00> (ø)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java	90.45% <66.66%> (-0.13%)	206.00 <0.00> (ø)
...n/java/org/batfish/datamodel/VrfLeakingConfig.java	90.90% <88.00%> (-3.54%)	16.00 <4.00> (+2.00)	⬇️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java	83.47% <100.00%> (+0.05%)	144.00 <0.00> (ø)
...batfish/representation/cisco/CiscoConversions.java	88.16% <100.00%> (ø)	188.00 <0.00> (ø)
...tfish/representation/cisco/CiscoIosDynamicNat.java	72.41% <0.00%> (-12.21%)	52.00% <0.00%> (+6.00%)	⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java	54.76% <0.00%> (-4.77%)	13.00% <0.00%> (-2.00%)
...atfish/representation/cisco/CiscoIosStaticNat.java	62.31% <0.00%> (-2.90%)	16.00% <0.00%> (+3.00%)	⬇️
...org/batfish/datamodel/flow/BidirectionalTrace.java	81.81% <0.00%> (-2.28%)	14.00% <0.00%> (-1.00%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java	70.93% <0.00%> (-0.59%)	90.00% <0.00%> (-1.00%)
... and 7 more

[corinaminer]

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @progwriter)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/VrfLeakingConfig.java, line 175 at r1 (raw file):

    @Override
    public boolean equals(Object o) {

@Nullable

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/VrfLeakingConfig.java, line 204 at r1 (raw file):

    private static BgpLeakConfig jsonCreate(
        @JsonProperty(PROP_ATTACH_ROUTE_TARGET) ExtendedCommunity attachRouteTarget) {
      return new BgpLeakConfig(attachRouteTarget);

should this check that attachRouteTarget is nonnull?

[progwriter]

Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @corinaminer)

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/VrfLeakingConfig.java, line 175 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

@Nullable

done

---

projects/batfish-common-protocol/src/main/java/org/batfish/datamodel/VrfLeakingConfig.java, line 204 at r1 (raw file):

Previously, corinaminer (Corina Miner) wrote…

should this check that attachRouteTarget is nonnull?

done

[corinaminer]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved