Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAN: support updating weight in BGP policy rules #6578

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

progwriter
Copy link
Contributor

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #6578 (9c5e6e5) into master (2a24352) will decrease coverage by 0.01%.
The diff coverage is 68.42%.

@@             Coverage Diff              @@
##             master    #6578      +/-   ##
============================================
- Coverage     73.41%   73.40%   -0.02%     
+ Complexity    35755    35753       -2     
============================================
  Files          2837     2838       +1     
  Lines        144303   144321      +18     
  Branches      17463    17465       +2     
============================================
- Hits         105934   105932       -2     
- Misses        29973    29983      +10     
- Partials       8396     8406      +10     
Impacted Files Coverage Δ Complexity Δ
...presentation/palo_alto/PolicyRuleUpdateWeight.java 50.00% <50.00%> (ø) 4.00 <4.00> (?)
...rammar/palo_alto/PaloAltoConfigurationBuilder.java 87.65% <100.00%> (+0.01%) 472.00 <1.00> (+1.00)
.../batfish/representation/palo_alto/Conversions.java 75.69% <100.00%> (+0.16%) 15.00 <0.00> (ø)
...g/batfish/representation/palo_alto/PolicyRule.java 94.28% <100.00%> (+0.53%) 19.00 <3.00> (+2.00)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) 6.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.45% <0.00%> (-0.32%) 206.00% <0.00%> (-1.00%)
... and 4 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@progwriter progwriter merged commit 8334de4 into batfish:master Jan 19, 2021
@progwriter progwriter deleted the pan-weight branch January 19, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants