Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpsecPeerConfig: Require valid local address #6581

Merged
merged 3 commits into from Jan 21, 2021

Conversation

corinaminer
Copy link
Contributor

Building the IPsec topology can fail if we create peer configs with invalid (Ip.AUTO) local addresses.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #6581 (7e26ae2) into master (5f3a9b4) will decrease coverage by 0.02%.
The diff coverage is 27.94%.

@@             Coverage Diff              @@
##             master    #6581      +/-   ##
============================================
- Coverage     73.40%   73.38%   -0.03%     
+ Complexity    35763    35759       -4     
============================================
  Files          2838     2838              
  Lines        144327   144380      +53     
  Branches      17465    17475      +10     
============================================
- Hits         105949   105948       -1     
- Misses        29978    30018      +40     
- Partials       8400     8414      +14     
Impacted Files Coverage Δ Complexity Δ
...ish/representation/arista/AristaConfiguration.java 58.25% <0.00%> (-0.04%) 178.00 <0.00> (ø)
...org/batfish/representation/arista/Conversions.java 21.55% <0.00%> (-0.19%) 30.00 <0.00> (ø)
.../representation/cisco_xr/CiscoXrConfiguration.java 52.75% <0.00%> (-0.04%) 109.00 <0.00> (ø)
...sh/representation/cisco_xr/CiscoXrConversions.java 29.58% <0.00%> (-0.51%) 49.00 <0.00> (ø)
...batfish/representation/vyos/VyosConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/org/batfish/datamodel/IpsecPeerConfig.java 92.00% <33.33%> (-8.00%) 6.00 <0.00> (ø)
...batfish/representation/cisco/CiscoConversions.java 87.45% <59.09%> (-0.82%) 190.00 <7.00> (+1.00) ⬇️
...h/representation/juniper/JuniperConfiguration.java 88.42% <60.00%> (-0.03%) 464.00 <0.00> (ø)
...tfish/representation/cisco/CiscoConfiguration.java 86.60% <100.00%> (+<0.01%) 507.00 <1.00> (+1.00)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
... and 12 more

Copy link
Contributor

@progwriter progwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@corinaminer corinaminer merged commit 1aa2589 into master Jan 21, 2021
@corinaminer corinaminer deleted the ipsec-peer-real-local-ip branch January 21, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants