FRR: Guard against BGP interface neighbor on an undefined interface

[ratulm]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6588 (0d35c67) into master (4f9ee6f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6588      +/-   ##
============================================
- Coverage     73.38%   73.38%   -0.01%     
+ Complexity    35769    35766       -3     
============================================
  Files          2839     2839              
  Lines        144403   144408       +5     
  Branches      17476    17477       +1     
============================================
- Hits         105977   105976       -1     
- Misses        30016    30019       +3     
- Partials       8410     8413       +3     

Impacted Files	Coverage Δ	Complexity Δ
...ish/representation/cumulus/CumulusConversions.java	91.82% <100.00%> (+0.05%)	192.00 <0.00> (+1.00)
...col/src/main/java/org/batfish/role/InferRoles.java	89.54% <0.00%> (-1.37%)	50.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java	60.37% <0.00%> (-1.26%)	43.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java	82.18% <0.00%> (-0.32%)	70.00% <0.00%> (-1.00%)

[dhalperi]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel and @ratulm)

---

projects/batfish/src/test/java/org/batfish/representation/cumulus/CumulusConversionsTest.java, line 1894 at r2 (raw file):

  @Test
  public void testAddBgpNeighbor_undefinedInterface() {
    // set up the VI bgp process

this is a tossup comment.

Even though it's a "worse" test, I'd prefer a test that started from config snippets. Even though it's more e2e-y, that's more robust to changing VS model - we've seen recently that these get hard to maintain e.g., if we refactor some of the VS or conversion code slightly.

[arifogel]

Reviewed 2 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved