Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaloAlto: BGP peers send communities unconditionally #6601

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

dhalperi
Copy link
Member

We still need to implement update community and update extended-community
variants that aren't none, but this gets us going.

We still need to implement `update community` and `update extended-community`
variants that aren't `none`, but this gets us going.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #6601 (59ba678) into master (4c32945) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6601      +/-   ##
============================================
- Coverage     73.41%   73.39%   -0.02%     
+ Complexity    35819    35807      -12     
============================================
  Files          2842     2842              
  Lines        144569   144571       +2     
  Branches      17492    17492              
============================================
- Hits         106131   106114      -17     
- Misses        30026    30036      +10     
- Partials       8412     8421       +9     
Impacted Files Coverage Δ Complexity Δ
...epresentation/palo_alto/PaloAltoConfiguration.java 88.89% <100.00%> (+0.01%) 398.00 <0.00> (ø)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...ava/org/batfish/datamodel/bgp/Layer2VniConfig.java 80.00% <0.00%> (-2.00%) 13.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.45% <0.00%> (-0.32%) 206.00% <0.00%> (-1.00%)
...a/org/batfish/representation/aws/LoadBalancer.java 82.18% <0.00%> (-0.32%) 70.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 86.19% <0.00%> (-0.28%) 249.00% <0.00%> (ø%)
... and 2 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit fb81317 into batfish:master Jan 29, 2021
@dhalperi dhalperi deleted the pan-community branch January 29, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants