Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp: fix detection of new BGP sessions #6606

Merged
merged 4 commits into from
Feb 2, 2021

Commits on Jan 31, 2021

  1. bgp: fix detection of new BGP sessions

    Fix a bug introduced in refactoring from batfish#6251, where
    some routes would not be exchanged on BGP links that come up after
    the snapshot starts. Fairly rare in datacenters, because BGP links in
    datacenters are usually ebgp singlehop.
    
    When sending routes to new links, we need to use the main RIB from
    the previous round rather than the current RIB, because depending on
    iteration order of the current round the current RIB may include
    routes that were not yet advertised in the previous round. This adds
    some memory overhead, but pointers to the routes are much smaller
    than the routes themselves, so this should be less than 10%.
    
    Add a test.
    dhalperi committed Jan 31, 2021
    Configuration menu
    Copy the full SHA
    6baf244 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Configuration menu
    Copy the full SHA
    94699c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    955b074 View commit details
    Browse the repository at this point in the history
  3. Rewrite to:

    * make invariants more clear and enforced in only one place
    * not track the previous entire RIB unless necessary
    
    The main thing missing was to defer processing of external
    advertisements to the first round of BGP instead of doing it
    in the neutral zone between IGP and EGP computations.
    dhalperi committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    67d1f7b View commit details
    Browse the repository at this point in the history