general: add warnings when Layer1 topology is invalid #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
And other similar storage issues.
dhalperi
force-pushed
the
layer1-warning
branch
from
aa02ceb
to
d088be1
Compare
Codecov Report
@@ Coverage Diff @@
## master #6611 +/- ##
============================================
- Coverage 73.42% 73.41% -0.02%
+ Complexity 35831 35826 -5
============================================
Files 2842 2842
Lines 144606 144624 +18
Branches 17502 17503 +1
============================================
- Hits 106177 106170 -7
- Misses 30006 30026 +20
- Partials 8423 8428 +5
|
arifogel
reviewed
Feb 8, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)
a discussion (no related file):
It's been a while since I looked at logging. Is the double-logging intentional?
Is one recorded in snapshot, and the other for runtime logging?
dhalperi
commented
Feb 8, 2021
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
a discussion (no related file):
Previously, arifogel (Ari Fogel) wrote…
It's been a while since I looked at logging. Is the double-logging intentional?
Is one recorded in snapshot, and the other for runtime logging?
Right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And other similar storage issues.