Cumulus/FRR: split NCLU and FRR #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- NCLU from FRR side
- Concat, Frr, Interfaces, Ports from NCLU side
* Rewrite some VS tests with the appropriate vendor
* Delete InterfaceConverter in NCLU side
|
This change is |
dhalperi
commented
Feb 15, 2021
There was a problem hiding this comment.
Reviewed 108 of 113 files at r1.
Reviewable status: 96 of 118 files reviewed, all discussions resolved (waiting on @dhalperi)
They were always unused, just became exposed by this work
Codecov Report
@@ Coverage Diff @@
## master #6630 +/- ##
============================================
- Coverage 73.41% 73.37% -0.04%
- Complexity 35871 36365 +494
============================================
Files 2847 2916 +69
Lines 144720 146708 +1988
Branches 17514 17686 +172
============================================
+ Hits 106249 107650 +1401
- Misses 30047 30567 +520
- Partials 8424 8491 +67
|
arifogel
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Reviewed 4 of 113 files at r1, 25 of 27 files at r2, 23 of 23 files at r4, 23 of 24 files at r5, 4 of 4 files at r6, 1 of 1 files at r7.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown and @sfraint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two completely different implementations, and the weird things we've done to
make them one are holding us back.
cumulus_nclupackage.CumulusNodeConfigurationabstraction