Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JunOS: fix parsing range of from-color, then-tag, from-tag, then-color #6645

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

dhalperi
Copy link
Member

This is for #6335

Note that there does not appear to be a from color2. Add warnings where appropriate.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #6645 (8280331) into master (d3b6cdf) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff            @@
##             master    #6645   +/-   ##
=========================================
  Coverage     73.46%   73.46%           
- Complexity    36473    36487   +14     
=========================================
  Files          2917     2918    +1     
  Lines        146887   146920   +33     
  Branches      17710    17716    +6     
=========================================
+ Hits         107908   107936   +28     
+ Misses        30476    30475    -1     
- Partials       8503     8509    +6     
Impacted Files Coverage Δ Complexity Δ
...va/org/batfish/representation/juniper/PsFroms.java 92.77% <ø> (+3.61%) 34.00 <0.00> (+1.00)
...fish/datamodel/routing_policy/expr/MatchColor.java 28.57% <33.33%> (ø) 2.00 <1.00> (ø)
.../org/batfish/representation/juniper/PsThenTag.java 76.92% <76.92%> (ø) 6.00 <6.00> (?)
...fish/grammar/flatjuniper/ConfigurationBuilder.java 72.66% <100.00%> (+0.13%) 876.00 <5.00> (+4.00)
...rg/batfish/representation/juniper/PsFromColor.java 83.33% <100.00%> (+83.33%) 6.00 <6.00> (+6.00)
.../org/batfish/representation/juniper/PsFromTag.java 91.66% <100.00%> (+11.66%) 7.00 <6.00> (+5.00)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (-2.64%) 15.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.09% <0.00%> (-1.82%) 49.00% <0.00%> (-2.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 62.89% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
... and 3 more

Copy link
Contributor

@corinaminer corinaminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @arifogel)

@dhalperi dhalperi merged commit 4b5d05e into batfish:master Feb 19, 2021
@dhalperi dhalperi deleted the junos-color-tag branch February 19, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants