No BGP Neighbor

[jawyoonis]

• No neighbor under ipv4 Unicas family address was not parse for no neigbor for ipv6

[batfish-bot]

This change is 

[ratulm]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @jawyoonis)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cumulus_frr/CumulusFrr_bgp.g4, line 366 at r1 (raw file):

sbafi_no
:
sbafi_no_neighbor

indent this line for consistency and readability.

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cumulus_frr/CumulusFrr_bgp.g4, line 375 at r1 (raw file):

   sbafi_no_activate
   )
   NEWLINE

Remove the NEWLINE from there and add to the sbafi_no_activate rule after ACTIVATE

---

projects/batfish/src/main/java/org/batfish/grammar/cumulus_frr/CumulusFrrConfigurationBuilder.java, line 892 at r1 (raw file):

    if(_currentBgpNeighborIpv4UnicastAddressFamily==null){
      return;
    }_currentBgpNeighborIpv4UnicastAddressFamily.setActivated(false);

run the formatting tool to fix such formatting issues

[ratulm]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @jawyoonis and @ratulm)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cumulus_frr/CumulusFrr_bgp.g4, line 374 at r2 (raw file):

  (
   sbafi_no_activate
   )

nit: the closing parenthesis is not aligned with the opening one.

[ratulm]

Reviewed 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[codecov]

Codecov Report

Merging #6654 (6f98589) into master (45c5047) will increase coverage by 0.05%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #6654      +/-   ##
============================================
+ Coverage     73.43%   73.49%   +0.05%     
- Complexity    35842    36576     +734     
============================================
  Files          2842     2927      +85     
  Lines        144622   147289    +2667     
  Branches      17504    17763     +259     
============================================
+ Hits         106207   108245    +2038     
- Misses        29996    30516     +520     
- Partials       8419     8528     +109     

Impacted Files	Coverage Δ	Complexity Δ
...ar/cumulus_frr/CumulusFrrConfigurationBuilder.java	76.85% <75.00%> (-0.15%)	210.00 <9.00> (+25.00)	⬇️
.../java/org/batfish/representation/cumulus/Bond.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-10.00%)
.../java/org/batfish/representation/cumulus/Vlan.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-10.00%)
...h/representation/cumulus/CumulusInterfaceType.java	0.00% <0.00%> (-100.00%)	0.00% <0.00%> (-1.00%)
.../org/batfish/representation/cumulus/Interface.java	4.25% <0.00%> (-91.49%)	1.00% <0.00%> (-26.00%)
...a/org/batfish/representation/cumulus/Loopback.java	0.00% <0.00%> (-73.69%)	0.00% <0.00%> (-9.00%)
...ava/org/batfish/representation/cumulus/Bridge.java	57.89% <0.00%> (-42.11%)	3.00% <0.00%> (-5.00%)
.../representation/cumulus/InterfaceClagSettings.java	70.37% <0.00%> (-29.63%)	13.00% <0.00%> (-1.00%)
...ish/representation/cumulus/CumulusConversions.java	81.41% <0.00%> (-10.42%)	179.00% <0.00%> (-13.00%)
...n/java/org/batfish/representation/cumulus/Vrf.java	90.90% <0.00%> (-9.10%)	5.00% <0.00%> (-1.00%)
... and 189 more