Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumulus frr parse and convert route-map set metric-type #6656

Merged
merged 1 commit into from Feb 24, 2021

Conversation

arifogel
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #6656 (364164e) into master (c7d00a4) will decrease coverage by 0.00%.
The diff coverage is 68.18%.

@@             Coverage Diff              @@
##             master    #6656      +/-   ##
============================================
- Coverage     73.49%   73.49%   -0.01%     
- Complexity    36577    36584       +7     
============================================
  Files          2928     2930       +2     
  Lines        147294   147316      +22     
  Branches      17763    17764       +1     
============================================
+ Hits         108251   108265      +14     
- Misses        30515    30521       +6     
- Partials       8528     8530       +2     
Impacted Files Coverage Δ Complexity Δ
.../representation/cumulus/RouteMapSetMetricType.java 50.00% <50.00%> (ø) 2.00 <2.00> (?)
...ar/cumulus_frr/CumulusFrrConfigurationBuilder.java 76.83% <62.50%> (-0.15%) 212.00 <2.00> (+2.00) ⬇️
.../batfish/representation/cumulus/RouteMapEntry.java 98.50% <100.00%> (+0.06%) 42.00 <2.00> (+2.00)
...ish/representation/cumulus/RouteMapMetricType.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@arifogel arifogel merged commit 13d9e3f into batfish:master Feb 24, 2021
@arifogel arifogel deleted the ari-frr-set-metric-type branch February 24, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants