Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrift: upgrade #6666

Merged
merged 1 commit into from Feb 27, 2021
Merged

thrift: upgrade #6666

merged 1 commit into from Feb 27, 2021

Conversation

dhalperi
Copy link
Member

This is for CVE-2020-13949.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #6666 (ff7350e) into master (016a262) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6666      +/-   ##
============================================
- Coverage     73.53%   73.51%   -0.02%     
+ Complexity    36663    36655       -8     
============================================
  Files          2934     2934              
  Lines        147476   147476              
  Branches      17776    17776              
============================================
- Hits         108443   108424      -19     
- Misses        30501    30515      +14     
- Partials       8532     8537       +5     
Impacted Files Coverage Δ Complexity Δ
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.32% <0.00%> (-0.32%) 206.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (-0.31%) 247.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 84.50% <0.00%> (-0.27%) 249.00% <0.00%> (ø%)
...tfish/representation/cisco/CiscoConfiguration.java 86.51% <0.00%> (-0.14%) 508.00% <0.00%> (-1.00%)

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 7bbbec7 into batfish:master Feb 27, 2021
@dhalperi dhalperi deleted the apache-thrift-up branch February 27, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants