Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OspfRoutingProcess: fix redistribution of inter-area routes #6667

Merged
merged 1 commit into from Mar 1, 2021

Conversation

dhalperi
Copy link
Member

Need to use the summarization filter from the source area,
not the destination area.

Need to use the summarization filter from the source area,
not the destination area.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #6667 (9cce4d2) into master (7bbbec7) will increase coverage by 0.00%.
The diff coverage is 93.33%.

@@            Coverage Diff            @@
##             master    #6667   +/-   ##
=========================================
  Coverage     73.52%   73.52%           
  Complexity    36657    36657           
=========================================
  Files          2934     2934           
  Lines        147476   147486   +10     
  Branches      17776    17776           
=========================================
+ Hits         108425   108437   +12     
+ Misses        30515    30514    -1     
+ Partials       8536     8535    -1     
Impacted Files Coverage Δ Complexity Δ
...org/batfish/dataplane/ibdp/OspfRoutingProcess.java 88.60% <93.33%> (+0.67%) 165.00 <3.00> (+1.00)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, all discussions resolved


projects/batfish/src/main/java/org/batfish/dataplane/ibdp/OspfRoutingProcess.java, line 961 at r1 (raw file):

              return areaSummaryFilter.permits(r.getRoute().getNetwork());
            })
        // Overwrite area on the route before sending it out

FYI @corinaminer confirmed manually that the filter in dest area is not used

@arifogel arifogel removed the request for review from corinaminer March 1, 2021 19:27
Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 306d90f into batfish:master Mar 1, 2021
@dhalperi dhalperi deleted the ospf-area-summarization branch March 1, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants