Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco ios support vrf export map #6694

Merged
merged 2 commits into from
Mar 5, 2021

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Mar 5, 2021

No description provided.

@arifogel arifogel requested a review from dhalperi March 5, 2021 01:45
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)


projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java, line 1773 at r1 (raw file):

.stream()

Not sure what the semantic change is from forEach on the stream vs the iterable?

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @dhalperi)


projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java, line 1773 at r1 (raw file):

Previously, dhalperi (Dan Halperin) wrote…
.stream()

Not sure what the semantic change is from forEach on the stream vs the iterable?

There was a filter there in an intermediate version of the code. Removed.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #6694 (e124a8b) into master (4694f0f) will increase coverage by 0.00%.
The diff coverage is 94.02%.

@@            Coverage Diff            @@
##             master    #6694   +/-   ##
=========================================
  Coverage     73.58%   73.59%           
- Complexity    36856    36861    +5     
=========================================
  Files          2938     2938           
  Lines        147987   148050   +63     
  Branches      17830    17832    +2     
=========================================
+ Hits         108899   108953   +54     
- Misses        30522    30528    +6     
- Partials       8566     8569    +3     
Impacted Files Coverage Δ Complexity Δ
...batfish/representation/cisco/CiscoConversions.java 87.83% <93.44%> (+0.37%) 198.00 <7.00> (+8.00)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 67.01% <100.00%> (+0.03%) 1315.00 <1.00> (+1.00)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) 15.00% <0.00%> (-1.00%)
...tfish/representation/cisco/CiscoConfiguration.java 86.56% <0.00%> (-0.13%) 512.00% <0.00%> (-1.00%)

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit fc292cc into batfish:master Mar 5, 2021
@arifogel arifogel deleted the ari-ios-vrf-export-map-2 branch March 5, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants