-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cisco ios support vrf export map #6694
Conversation
36de31d
to
eec16dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)
projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java, line 1773 at r1 (raw file):
.stream()
Not sure what the semantic change is from forEach on the stream vs the iterable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @dhalperi)
projects/batfish/src/main/java/org/batfish/representation/cisco/CiscoConversions.java, line 1773 at r1 (raw file):
Previously, dhalperi (Dan Halperin) wrote…
.stream()
Not sure what the semantic change is from forEach on the stream vs the iterable?
There was a filter there in an intermediate version of the code. Removed.
Codecov Report
@@ Coverage Diff @@
## master #6694 +/- ##
=========================================
Coverage 73.58% 73.59%
- Complexity 36856 36861 +5
=========================================
Files 2938 2938
Lines 147987 148050 +63
Branches 17830 17832 +2
=========================================
+ Hits 108899 108953 +54
- Misses 30522 30528 +6
- Partials 8566 8569 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
No description provided.