Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OspfRoutingProcess: filter summarized routes earlier #6717

Merged
merged 2 commits into from Mar 11, 2021

Conversation

dhalperi
Copy link
Member

Rather than putting all intra-area routes into the inter-area RIB and then not
sending them if they are summarized, just don't put them in the inter-area RIB
in the first place.

@dhalperi dhalperi requested a review from arifogel March 11, 2021 07:20
@batfish-bot
Copy link

This change is Reviewable

Rather than putting all intra-area routes into the inter-area RIB and then not
sending them if they are summarized, just don't put them in the inter-area RIB
in the first place.
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #6717 (ad84b72) into master (7868f4e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6717      +/-   ##
============================================
- Coverage     73.71%   73.69%   -0.02%     
+ Complexity    37115    37108       -7     
============================================
  Files          2947     2947              
  Lines        148682   148685       +3     
  Branches      17882    17883       +1     
============================================
- Hits         109599   109577      -22     
- Misses        30504    30522      +18     
- Partials       8579     8586       +7     
Impacted Files Coverage Δ Complexity Δ
...org/batfish/dataplane/ibdp/OspfRoutingProcess.java 92.86% <100.00%> (+0.03%) 187.00 <2.00> (+3.00)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) 22.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 89.54% <0.00%> (-1.37%) 50.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.42% <0.00%> (-0.70%) 245.00% <0.00%> (-3.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.40% <0.00%> (-0.31%) 210.00% <0.00%> (-1.00%)
...ain/java/org/batfish/storage/FileBasedStorage.java 84.50% <0.00%> (-0.27%) 249.00% <0.00%> (ø%)
...tfish/representation/cisco/CiscoConfiguration.java 86.56% <0.00%> (-0.13%) 512.00% <0.00%> (-1.00%)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 5d171c9 into batfish:master Mar 11, 2021
@dhalperi dhalperi deleted the ospf-filter-earlier branch March 11, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants