OSPF: not-advertised summaries do not install a discard route

[dhalperi]

Since the summary isn't advertised, there's no need to install this discard route to
prevent a loop that can't happen.

[batfish-bot]

This change is 

[arifogel]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)

---

projects/batfish/src/main/java/org/batfish/dataplane/ibdp/OspfRoutingProcess.java, line 745 at r1 (raw file):

        .forEach(
            (prefix, summary) -> {
              if (summary.getAdvertised()) {

This is not correct for all vendors.

[codecov]

Codecov Report

Merging #6724 (fc42940) into master (75e21f9) will decrease coverage by 0.00%.
The diff coverage is 53.22%.

@@             Coverage Diff              @@
##             master    #6724      +/-   ##
============================================
- Coverage     70.02%   70.02%   -0.01%     
- Complexity    37657    37662       +5     
============================================
  Files          3097     3097              
  Lines        159641   159679      +38     
  Branches      19473    19482       +9     
============================================
+ Hits         111793   111809      +16     
- Misses        38837    38855      +18     
- Partials       9011     9015       +4     

Impacted Files	Coverage Δ	Complexity Δ
...sh/grammar/arista/AristaControlPlaneExtractor.java	35.03% <0.00%> (-0.05%)	615.00 <0.00> (ø)
...sh/grammar/cisco_asa/AsaControlPlaneExtractor.java	15.17% <0.00%> (-0.02%)	263.00 <0.00> (ø)
...ish/representation/arista/AristaConfiguration.java	58.25% <0.00%> (ø)	178.00 <0.00> (ø)
...ish/representation/cisco_asa/AsaConfiguration.java	41.37% <0.00%> (ø)	200.00 <0.00> (ø)
.../representation/cisco_xr/CiscoXrConfiguration.java	52.75% <0.00%> (ø)	109.00 <0.00> (ø)
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java	20.14% <37.50%> (+0.01%)	341.00 <0.00> (ø)
...fish/grammar/cisco/CiscoControlPlaneExtractor.java	61.48% <50.00%> (-0.02%)	1148.00 <0.00> (+1.00)	⬇️
...va/org/batfish/datamodel/ospf/OspfAreaSummary.java	95.23% <92.30%> (-4.77%)	15.00 <9.00> (+5.00)	⬇️
...org/batfish/dataplane/ibdp/OspfRoutingProcess.java	92.87% <100.00%> (+0.01%)	188.00 <6.00> (+1.00)
...fish/grammar/flatjuniper/ConfigurationBuilder.java	72.87% <100.00%> (+0.02%)	885.00 <0.00> (ø)
... and 9 more

[arifogel]

Reviewed 23 of 23 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved