Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batfish: remove all SMT and z3-related code and tests #6741

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

dhalperi
Copy link
Member

Preserve TransferBDD and the things it uses.

Delete:

  • z3 install script, maven config, bazel config
  • smt package everywhere
  • abstraction package everywhere, except preserving the InterfacePolicy
    class used by TransferBDD.
  • utility classes, matchers, and the like that were smt-related.
  • unused classes and code

Preserve TransferBDD and the things it uses.

Delete:
* z3 install script, maven config, bazel config
* smt package everywhere
* abstraction package everywhere, except preserving the InterfacePolicy
  class used by TransferBDD.
* utility classes, matchers, and the like that were smt-related.
* unused classes and code
@dhalperi dhalperi requested a review from arifogel March 16, 2021 23:55
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #6741 (90f2861) into master (0430c99) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6741      +/-   ##
============================================
- Coverage     69.86%   69.49%   -0.38%     
+ Complexity    37627    35926    -1701     
============================================
  Files          3095     3015      -80     
  Lines        159970   153131    -6839     
  Branches      19504    18407    -1097     
============================================
- Hits         111766   106414    -5352     
+ Misses        39141    38112    -1029     
+ Partials       9063     8605     -458     
Impacted Files Coverage Δ Complexity Δ
.../main/java/org/batfish/minesweeper/AstVisitor.java 0.00% <ø> (-60.79%) 0.00 <0.00> (-12.00)
...ava/org/batfish/minesweeper/utils/PrefixUtils.java 37.50% <ø> (-15.14%) 2.00 <0.00> (-14.00)
...r/src/main/java/org/batfish/minesweeper/Graph.java 33.28% <100.00%> (-43.20%) 61.00 <3.00> (-125.00)
...c/main/java/org/batfish/minesweeper/GraphEdge.java 0.00% <0.00%> (-75.76%) 0.00% <0.00%> (-21.00%)
...entation/cisco/RouteMapSetDeleteCommunityLine.java 0.00% <0.00%> (-66.67%) 0.00% <0.00%> (-2.00%)
...ain/java/org/batfish/minesweeper/utils/MsPair.java 0.00% <0.00%> (-58.83%) 0.00% <0.00%> (-5.00%)
...va/org/batfish/minesweeper/collections/Table2.java 45.16% <0.00%> (-54.84%) 6.00% <0.00%> (-8.00%)
...rc/main/java/org/batfish/minesweeper/Protocol.java 43.58% <0.00%> (-41.03%) 4.00% <0.00%> (-21.00%)
... and 22 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 306 of 309 files at r1, 6 of 6 files at r2, 10 of 10 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit 865bb18 into batfish:master Mar 17, 2021
@dhalperi dhalperi deleted the no-z3 branch March 17, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants