-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batfish: remove all SMT and z3-related code and tests #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserve TransferBDD and the things it uses. Delete: * z3 install script, maven config, bazel config * smt package everywhere * abstraction package everywhere, except preserving the InterfacePolicy class used by TransferBDD. * utility classes, matchers, and the like that were smt-related. * unused classes and code
Codecov Report
@@ Coverage Diff @@
## master #6741 +/- ##
============================================
- Coverage 69.86% 69.49% -0.38%
+ Complexity 37627 35926 -1701
============================================
Files 3095 3015 -80
Lines 159970 153131 -6839
Branches 19504 18407 -1097
============================================
- Hits 111766 106414 -5352
+ Misses 39141 38112 -1029
+ Partials 9063 8605 -458
|
arifogel
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 306 of 309 files at r1, 6 of 6 files at r2, 10 of 10 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve TransferBDD and the things it uses.
Delete:
class used by TransferBDD.