CommunitySetMatchExprVarCollector: do not crash on collecting unsupported structures #6750
Conversation
…rted structures Instead, defer that crashing to validation time. This enables SearchRoutePolicies to run on devices where only some of the route policies can be successfully analyzed.
|
This change is |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)
a discussion (no related file):
This looks great, thanks. Note that the same issue arises with UnsupportedOperationExceptions in CommunityMatchExprVarCollector.
Codecov Report
@@ Coverage Diff @@
## master #6750 +/- ##
==========================================
Coverage 69.51% 69.52%
- Complexity 35913 35945 +32
==========================================
Files 3011 3013 +2
Lines 153087 153192 +105
Branches 18404 18405 +1
==========================================
+ Hits 106424 106511 +87
- Misses 38064 38073 +9
- Partials 8599 8608 +9 |
There was a problem hiding this comment.
Dismissed @millstein from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved
a discussion (no related file):
Previously, millstein (Todd Millstein) wrote…
This looks great, thanks. Note that the same issue arises with UnsupportedOperationExceptions in CommunityMatchExprVarCollector.
Done.
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
Previously, dhalperi (Dan Halperin) wrote…
Done.
Done was a weird auto-add. Ack, next work.
Instead, defer that crashing to validation time. This enables SearchRoutePolicies to
run on devices where only some of the route policies can be successfully analyzed.