Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NX-OS: fix ospf area range #6805

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

dhalperi
Copy link
Member

We were incorrectly converting summary-address as an inter-area summary.

Fix #6794

We were incorrectly converting summary-address as an inter-area summary.
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #6805 (8affacd) into master (4b2cbfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #6805   +/-   ##
=========================================
  Coverage     69.88%   69.89%           
- Complexity    36274    36285   +11     
=========================================
  Files          3031     3031           
  Lines        153528   153549   +21     
  Branches      18422    18427    +5     
=========================================
+ Hits         107298   107328   +30     
+ Misses        37581    37573    -8     
+ Partials       8649     8648    -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/batfish/datamodel/PrefixRange.java 82.35% <100.00%> (+0.72%) 21.00 <1.00> (+1.00)
...mar/cisco_nxos/CiscoNxosControlPlaneExtractor.java 76.63% <100.00%> (ø) 1070.00 <0.00> (ø)
...resentation/cisco_nxos/CiscoNxosConfiguration.java 87.33% <100.00%> (+0.08%) 393.00 <5.00> (+3.00)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.42% <0.00%> (-0.31%) 210.00% <0.00%> (-1.00%)
...h/grammar/fortios/FortiosConfigurationBuilder.java 93.08% <0.00%> (-0.15%) 373.00% <0.00%> (+4.00%) ⬇️
...ain/java/org/batfish/symbolic/IngressLocation.java 65.78% <0.00%> (ø) 15.00% <0.00%> (ø%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 71.51% <0.00%> (+0.58%) 91.00% <0.00%> (+1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.81% <0.00%> (+0.69%) 247.00% <0.00%> (+3.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (+4.76%) 15.00% <0.00%> (+2.00%)

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sfraint)

@dhalperi dhalperi merged commit 8bdd65d into batfish:master Mar 30, 2021
@dhalperi dhalperi deleted the nxos-ospf-area-range branch March 30, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco NX-OS: Area summary route missing due to parse warning, resulting in missing BGP route
3 participants