TransferBDD: Avoid crashing on common idioms for setting communities #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Exp) in the translation of a community set expression
|
This change is |
arifogel
reviewed
Mar 30, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #6812 +/- ##
============================================
- Coverage 69.90% 68.38% -1.53%
+ Complexity 36295 35378 -917
============================================
Files 3031 3031
Lines 153564 153566 +2
Branches 18430 18430
============================================
- Hits 107348 105015 -2333
- Misses 37572 40110 +2538
+ Partials 8644 8441 -203
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifies expressions of the form (InputCommunities - E), which is common in the translation of config commands to set communities, and ignores them rather than crashing.