Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBDP: detect oscillation in OSPF #6823

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Apr 1, 2021

No description provided.

@dhalperi dhalperi requested a review from arifogel April 1, 2021 17:44
@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #6823 (79ebae9) into master (818c58d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #6823      +/-   ##
============================================
- Coverage     69.93%   69.91%   -0.02%     
+ Complexity    36377    36364      -13     
============================================
  Files          3034     3034              
  Lines        153788   153790       +2     
  Branches      18454    18455       +1     
============================================
- Hits         107550   107525      -25     
- Misses        37588    37604      +16     
- Partials       8650     8661      +11     
Impacted Files Coverage Δ Complexity Δ
...g/batfish/dataplane/ibdp/IncrementalBdpEngine.java 88.60% <0.00%> (-0.39%) 76.00 <0.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) 6.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-5.96%) 13.00% <0.00%> (-3.00%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...org/batfish/datamodel/flow/BidirectionalTrace.java 81.81% <0.00%> (-2.28%) 14.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) 52.00% <0.00%> (-1.00%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) 90.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.65% <0.00%> (-0.31%) 247.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.42% <0.00%> (-0.31%) 210.00% <0.00%> (-1.00%)
... and 1 more

Copy link
Member

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dhalperi dhalperi merged commit fd170a7 into batfish:master Apr 1, 2021
@dhalperi dhalperi deleted the ospf-dont-infinite-loop branch April 1, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants