Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix static route activation condition #6824

Merged
merged 2 commits into from Apr 1, 2021

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Apr 1, 2021

  • if a static route matches its own next-hop, a matching route must be
    more specific

- if a static route matches its own next-hop, a matching route must be
more specific
@arifogel arifogel requested a review from dhalperi April 1, 2021 19:20
@batfish-bot
Copy link

This change is Reviewable

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #6824 (2664134) into master (fd170a7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6824      +/-   ##
============================================
- Coverage     70.07%   70.07%   -0.01%     
+ Complexity    36406    36401       -5     
============================================
  Files          3029     3029              
  Lines        153598   153601       +3     
  Branches      18412    18412              
============================================
- Hits         107640   107630      -10     
- Misses        37298    37305       +7     
- Partials       8660     8666       +6     
Impacted Files Coverage Δ Complexity Δ
...batfish/dataplane/protocols/StaticRouteHelper.java 94.44% <100.00%> (+1.11%) 7.00 <3.00> (ø)
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) 7.00% <0.00%> (-1.00%)
...batfish/representation/aws/LoadBalancerTarget.java 54.16% <0.00%> (-4.17%) 8.00% <0.00%> (ø%)
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) 18.00% <0.00%> (-1.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) 52.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 62.89% <0.00%> (-1.26%) 43.00% <0.00%> (-1.00%)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.42% <0.00%> (-0.31%) 210.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.50% <0.00%> (-0.16%) 246.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/PoolMgr.java 55.95% <0.00%> (+1.19%) 14.00% <0.00%> (+1.00%)

Copy link
Member Author

@arifogel arifogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@arifogel arifogel merged commit 50c04b8 into batfish:master Apr 1, 2021
@arifogel arifogel deleted the ari-sr-fix-activate branch April 1, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants