Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BgpRouteDiff: model changes to origin type #6855

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Apr 6, 2021

No description provided.

@batfish-bot
Copy link

This change is Reviewable

Copy link
Member Author

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @anothermattbrown and @ratulm)


projects/batfish/BUILD, line 116 at r1 (raw file):

        "//projects/batfish-common-protocol/src/test/java/org/batfish/common/matchers",
        "//projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/matchers",
        "//projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/questions:TestQuestion",

FYI bazel changes are just to enable me to run these tests on their own rather than as part of the entire commons module.


projects/batfish-common-protocol/src/test/java/org/batfish/datamodel/questions/BgpRouteDiffTest.java, line 91 at r1 (raw file):

hree

FYI three was already four.

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown)

@dhalperi dhalperi merged commit 14f9c47 into batfish:master Apr 6, 2021
@dhalperi dhalperi deleted the bgp-route-diff branch April 6, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants