IOS: improver parser recovery in router ospf #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhalperi
commented
Apr 6, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: 4 of 8 files reviewed, all discussions resolved (waiting on @dhalperi)
Codecov Report
@@ Coverage Diff @@
## master #6862 +/- ##
============================================
+ Coverage 70.34% 70.35% +0.01%
- Complexity 36520 36526 +6
============================================
Files 3021 3021
Lines 153716 153716
Branches 18436 18436
============================================
+ Hits 108127 108143 +16
+ Misses 36852 36838 -14
+ Partials 8737 8735 -2
|
Factoring out the inner rule prevents the parser accidentally staying in the loop for too long and eating past the end of router ospf
arifogel
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @corinaminer and @sfraint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factoring out the inner rule prevents the parser accidentally staying
in the loop for too long and eating past the end of router ospf