IOS-XR overhaul ipv4/6 access-list reference parsing

[arifogel]

No description provided.

[batfish-bot]

This change is 

[codecov]

Codecov Report

Merging #6884 (3340683) into master (8357bea) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master    #6884      +/-   ##
============================================
+ Coverage     70.74%   70.75%   +0.01%     
- Complexity    36617    36632      +15     
============================================
  Files          3008     3008              
  Lines        153208   153257      +49     
  Branches      18386    18399      +13     
============================================
+ Hits         108384   108440      +56     
+ Misses        36087    36069      -18     
- Partials       8737     8748      +11     

Impacted Files	Coverage Δ	Complexity Δ
.../representation/cisco_xr/CiscoXrConfiguration.java	53.53% <ø> (+0.27%)	115.00 <0.00> (+2.00)
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java	25.98% <90.00%> (+1.03%)	409.00 <23.00> (+21.00)
...representation/cisco_xr/CiscoXrStructureUsage.java	100.00% <100.00%> (ø)	3.00 <0.00> (ø)
...src/main/java/org/batfish/coordinator/PoolMgr.java	54.76% <0.00%> (-4.77%)	13.00% <0.00%> (-2.00%)
...col/src/main/java/org/batfish/role/InferRoles.java	91.36% <0.00%> (-1.37%)	52.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java	75.11% <0.00%> (-0.70%)	244.00% <0.00%> (-3.00%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java	70.93% <0.00%> (-0.59%)	90.00% <0.00%> (-1.00%)
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java	84.81% <0.00%> (-0.12%)	150.00% <0.00%> (-1.00%)
...org/batfish/representation/cisco_xr/Interface.java	56.52% <0.00%> (+1.08%)	67.00% <0.00%> (+1.00%)

[dhalperi]

Reviewed 12 of 13 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @arifogel)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cisco_xr/CiscoXr_mpls.g4, line 93 at r2 (raw file):

Quoted 7 lines of code…

mldpaf_null
:
   NO?
   (
      NEIGHBOR
   ) null_rest_of_line
;

general: get rid of the NO? , add _no and _no_null variants instead?

[arifogel]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dhalperi)

---

projects/batfish/src/main/antlr4/org/batfish/grammar/cisco_xr/CiscoXr_mpls.g4, line 93 at r2 (raw file):

Previously, dhalperi (Dan Halperin) wrote…

mldpaf_null
:
   NO?
   (
      NEIGHBOR
   ) null_rest_of_line
;

general: get rid of the NO? , add _no and _no_null variants instead?

I agree this should happen. However, there are 17 instances of NO? in this file alone, and the task is quite orthogonal to fixing access-list references.
Prefer to address in separate PR.