Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-XR parser overhaul numbers #6886

Merged
merged 8 commits into from Apr 9, 2021
Merged

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Apr 9, 2021

  • split DEC into UINT8, UINT16, UINT32, UINT64, UINT_BIG
  • add uint8, uint16, uint32, uint64, uint_big rules
  • add uint_legacy rule to replace all old references to DEC
  • update conversion functions

@batfish-bot
Copy link

This change is Reviewable

@arifogel arifogel requested a review from dhalperi April 9, 2021 20:13
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 1 of 1 files at r5, 23 of 23 files at r6, 1 of 1 files at r7, 1 of 1 files at r8.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6886 (7e9f254) into master (d9ccd71) will decrease coverage by 0.00%.
The diff coverage is 40.38%.

@@             Coverage Diff              @@
##             master    #6886      +/-   ##
============================================
- Coverage     70.78%   70.77%   -0.01%     
+ Complexity    36672    36664       -8     
============================================
  Files          3009     3009              
  Lines        153321   153317       -4     
  Branches      18407    18406       -1     
============================================
- Hits         108526   108508      -18     
- Misses        36056    36066      +10     
- Partials       8739     8743       +4     
Impacted Files Coverage Δ Complexity Δ
...sh/grammar/cisco_xr/parsing/CiscoXrBaseParser.java 100.00% <ø> (+40.00%) 1.00 <0.00> (-2.00) ⬆️
...grammar/cisco_xr/CiscoXrControlPlaneExtractor.java 25.98% <40.38%> (-0.01%) 408.00 <27.00> (-1.00)
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-4.77%) 13.00% <0.00%> (-2.00%)
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) 52.00% <0.00%> (-1.00%)
...main/java/org/batfish/datamodel/acl/AclTracer.java 62.42% <0.00%> (-1.28%) 42.00% <0.00%> (-1.00%)
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) 90.00% <0.00%> (-1.00%)
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.50% <0.00%> (-0.31%) 246.00% <0.00%> (-1.00%)

@dhalperi dhalperi merged commit a9dc6db into batfish:master Apr 9, 2021
@arifogel arifogel deleted the ari-xr-uint branch June 8, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants