Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frr set loopback interface type for default vrf loopback #7039

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Jun 2, 2021

No description provided.

@arifogel arifogel requested a review from dhalperi June 2, 2021 20:02
@batfish-bot
Copy link

This change is Reviewable

@arifogel arifogel requested a review from corinaminer June 2, 2021 20:10
Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #7039 (3abdbe7) into master (dfd9da7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7039      +/-   ##
============================================
- Coverage     71.91%   71.90%   -0.02%     
+ Complexity    37707    37700       -7     
============================================
  Files          3036     3036              
  Lines        154739   154740       +1     
  Branches      18563    18564       +1     
============================================
- Hits         111282   111260      -22     
- Misses        34574    34590      +16     
- Partials       8883     8890       +7     
Impacted Files Coverage Δ
...tion/cumulus/CumulusConcatenatedConfiguration.java 72.55% <100.00%> (+0.06%) ⬆️
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) ⬇️
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) ⬇️
.../org/batfish/dataplane/rib/RouteAdvertisement.java 83.67% <0.00%> (-4.09%) ⬇️
...col/src/main/java/org/batfish/role/InferRoles.java 91.36% <0.00%> (-1.37%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.57% <0.00%> (-0.55%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 84.50% <0.00%> (-0.53%) ⬇️
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 90.57% <0.00%> (-0.31%) ⬇️

@arifogel arifogel merged commit 9053587 into batfish:master Jun 2, 2021
@arifogel arifogel deleted the ari-frr-loopback-type branch June 2, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants