Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various vpn fixes #718

Merged
merged 2 commits into from
Dec 8, 2017
Merged

various vpn fixes #718

merged 2 commits into from
Dec 8, 2017

Conversation

arifogel
Copy link
Member

@arifogel arifogel commented Dec 8, 2017

  • consistently hash pre-shared-keys across vendors
  • properly add aws generated interfaces to aws nodes
  • set default ipsec and ike properties for cisco ipsec vpns

This change is Reviewable

- consistently hash pre-shared-keys across vendors
- properly add aws generated interfaces to aws nodes
- set default ipsec and ike properties for cisco ipsec vpns
@dhalperi
Copy link
Member

dhalperi commented Dec 8, 2017

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@dhalperi
Copy link
Member

dhalperi commented Dec 8, 2017

I'll take on updating refs.


Comments from Reviewable

@dhalperi
Copy link
Member

dhalperi commented Dec 8, 2017

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dhalperi dhalperi merged commit b003f12 into master Dec 8, 2017
@dhalperi dhalperi deleted the ari-fix-ipsec-vpn-stack-overflow branch December 8, 2017 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants