Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JunOS: handle ## SECRET-DATA after semicolon #7226

Merged
merged 1 commit into from Aug 5, 2021

Conversation

dhalperi
Copy link
Member

@dhalperi dhalperi commented Aug 5, 2021

Fix #7225.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #7226 (5e451b3) into master (5201666) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7226      +/-   ##
============================================
- Coverage     72.77%   72.76%   -0.01%     
+ Complexity    38890    38887       -3     
============================================
  Files          3102     3102              
  Lines        156835   156835              
  Branches      18820    18820              
============================================
- Hits         114129   114114      -15     
- Misses        33685    33697      +12     
- Partials       9021     9024       +3     
Impacted Files Coverage Δ
...g/batfish/datamodel/flow/IncomingSessionScope.java 84.61% <0.00%> (-15.39%) ⬇️
...rg/batfish/identifiers/StorageBasedIdResolver.java 85.29% <0.00%> (-5.89%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 59.52% <0.00%> (-1.20%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.42% <0.00%> (-0.55%) ⬇️
...ain/java/org/batfish/storage/FileBasedStorage.java 84.99% <0.00%> (-0.54%) ⬇️
...a/org/batfish/representation/juniper/BgpGroup.java 90.51% <0.00%> (+0.72%) ⬆️

Copy link
Member

@ratulm ratulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@dhalperi dhalperi merged commit d3856d3 into batfish:master Aug 5, 2021
@dhalperi dhalperi deleted the juniper-secret-data branch August 5, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bgpPeerConfiguration ASN Parsing Issue
3 participants