Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add regex to as path access lists #7250

Merged
merged 7 commits into from
Sep 20, 2021
Merged

feat: add regex to as path access lists #7250

merged 7 commits into from
Sep 20, 2021

Commits on Sep 16, 2021

  1. feat: add regex to as path access lists 

    - update lexer / parser
- update conversion
    @lukaskoenen
    lukaskoenen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    7738964 View commit details
    Browse the repository at this point in the history

  2. refactor: fix formatting errors

    @lukaskoenen
    lukaskoenen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    ac158d4 View commit details
    Browse the repository at this point in the history

  3. fix: add missing characters to correctly parse regexp 

    - extend valid characters for word token
    @lukaskoenen
    lukaskoenen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    c4522a8 View commit details
    Browse the repository at this point in the history

  4. refactor: changes required by review 

    - use assert in toLineAction
- extend grammar test when it comes to regular expressions
    @lukaskoenen
    lukaskoenen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    be20039 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. refactor: review changes 

    - move conversion to CumulusConversion
- add new fragment to represent valid chars for a regex
    @lukaskoenen
    lukaskoenen committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    c2a9775 View commit details
    Browse the repository at this point in the history

  2. fix: grammar 

    - fix error in grammar
- fix formatting in IpAsPathAccessListLine
    @lukaskoenen
    lukaskoenen committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f83aada View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. refactor: correct naming 

    - use correct suffix
- change REGEXP to REGEX
- remove regexp from CumulusFrr_common
    @lukaskoenen
    lukaskoenen committed Sep 18, 2021
    Configuration menu
    Copy the full SHA
    13563e6 View commit details
    Browse the repository at this point in the history