Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP route reflector should reflect RIB-failure routes #7398

Merged
merged 1 commit into from Sep 16, 2021

Conversation

arifogel
Copy link
Member

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #7398 (bb43f6f) into master (194f9b7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7398      +/-   ##
============================================
- Coverage     73.04%   73.04%   -0.01%     
  Complexity    39752    39752              
============================================
  Files          3176     3176              
  Lines        159140   159146       +6     
  Branches      19156    19159       +3     
============================================
+ Hits         116239   116242       +3     
+ Misses        33687    33684       -3     
- Partials       9214     9220       +6     
Impacted Files Coverage Δ
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 83.48% <100.00%> (+0.09%) ⬆️
.../datamodel/routing_policy/statement/Statement.java 72.72% <0.00%> (-9.10%) ⬇️
...src/main/java/org/batfish/coordinator/PoolMgr.java 54.76% <0.00%> (-5.96%) ⬇️
...ava/org/batfish/datamodel/bgp/Layer2VniConfig.java 80.00% <0.00%> (-2.00%) ⬇️
...ain/java/org/batfish/coordinator/WorkQueueMgr.java 70.93% <0.00%> (-0.59%) ⬇️
...src/main/java/org/batfish/coordinator/WorkMgr.java 75.37% <0.00%> (-0.32%) ⬇️
...tfish/representation/cisco/CiscoConfiguration.java 84.61% <0.00%> (-0.16%) ⬇️
...fish/grammar/cisco/CiscoControlPlaneExtractor.java 62.08% <0.00%> (+0.14%) ⬆️
...h/representation/cisco/RouteMapSetNextHopLine.java 83.33% <0.00%> (+83.33%) ⬆️

Copy link
Member

@dhalperi dhalperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corinaminer)

@dhalperi dhalperi merged commit b66ffc1 into batfish:master Sep 16, 2021
@arifogel arifogel deleted the ari-rr-reflect-rib-failure branch September 24, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants